Roadmap › Clean Code, Testing & Best Practices › Module: Team Practices
Lessons in this course (12)
11. Code review checklist
Intermediate★ Must knowLesson 11 of 12
- Correctness — does it do what the ticket says? Edge cases (null, empty, large, concurrent)?
- Tests — new behaviour covered? Bug fix has a regression test?
- Design — SOLID, no duplication, right layer, no unnecessary abstraction.
- Readability — names, function size, comments explain why.
- Performance — N+1 queries, loading whole tables, blocking async, missing indexes.
- Security — input validation, parameterised SQL, authorisation checks, no secrets in code, safe logging.
- Operability — logging, metrics, config, migrations, backward compatibility.
Tone: comment on the code, not the person; ask questions ("What happens if X is null?"); mark nits as optional; approve when good enough.